Skip to content

Conversation

@Banyc
Copy link
Member

@Banyc Banyc commented Dec 13, 2020

No description provided.

@Banyc Banyc requested a review from Oceania2018 as a code owner December 13, 2020 12:40
var x = tf.Variable(doubleNd);

var slice = x[":"];
Assert.ThrowsException<System.Exception>(
Copy link
Member

@Esther2013 Esther2013 Dec 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more clear if changing to ExpectedExceptionAttribute like below:

[TestMethod, Ignore]
[ExpectedException(typeof(System.Exception), "A userId of null was inappropriately allowed.")]
public void NullUserIdInConstructor()
{
   slice.assign(intNd);
}

@Oceania2018 Oceania2018 self-assigned this Dec 13, 2020
@Oceania2018 Oceania2018 removed their request for review December 13, 2020 21:30
@Oceania2018 Oceania2018 merged commit b6755cc into SciSharp:master Dec 13, 2020
Oceania2018 added a commit that referenced this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants